Skip to content

chore: Filter model presets by supported parameters#36339

Merged
iamjoel merged 1 commit into
mainfrom
fix/gpt-load-preset-not-work
May 18, 2026
Merged

chore: Filter model presets by supported parameters#36339
iamjoel merged 1 commit into
mainfrom
fix/gpt-load-preset-not-work

Conversation

@iamjoel
Copy link
Copy Markdown
Contributor

@iamjoel iamjoel commented May 18, 2026

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. javascript Pull requests that update javascript code labels May 18, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.94%. Comparing base (f4c02e4) to head (6fd4f9d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...e/model-parameter-modal/presets-parameter-utils.ts 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #36339   +/-   ##
=======================================
  Coverage   85.94%   85.94%           
=======================================
  Files        4454     4455    +1     
  Lines      211503   211521   +18     
  Branches    39515    39520    +5     
=======================================
+ Hits       181782   181801   +19     
+ Misses      26509    26508    -1     
  Partials     3212     3212           
Flag Coverage Δ
dify-ui 94.59% <ø> (ø)
web 86.56% <92.59%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 18, 2026
@iamjoel iamjoel added this pull request to the merge queue May 18, 2026
Merged via the queue into main with commit c057b5c May 18, 2026
33 checks passed
@iamjoel iamjoel deleted the fix/gpt-load-preset-not-work branch May 18, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants