refactor: convert isinstance chains to match/case pattern

[xxiaoxiong]

Summary

This PR refactors multiple chains to use Python's pattern (introduced in Python 3.10), improving code readability and maintainability.

Changes

Files Modified

1. services/tools/tools_transform_service.py

   • : Converted 3-branch isinstance chain to match/case

2. services/rag_pipeline/rag_pipeline.py

   • Datasource parameter handling: Converted isinstance checks for str/list types to match/case

3. core/tools/tool_label_manager.py

   • : Converted isinstance chain with union types to match/case

4. core/memory/token_buffer_memory.py

   • Content type handling: Converted TextPromptMessageContent/ImagePromptMessageContent checks to match/case

Benefits

• Improved readability: Match/case syntax is more declarative and easier to understand
• Better pattern matching: Leverages Python 3.10+ structural pattern matching
• Consistent with existing codebase: Many files already use match/case (e.g., , )

Testing

• All changes preserve existing behavior
• No functional changes, only syntax improvements
• Follows the same patterns already used in the codebase

#35902

[github-actions]

Pyrefly Type Coverage

Metric	Base	PR	Delta
Type coverage	0.00%	44.42%	+44.42%
Strict coverage	0.00%	43.95%	+43.95%
Typed symbols	0	22,535	+22,535
Untyped symbols	0	28,498	+28,498
Modules	0	2561	+2,561

[asukaminato0721]

@dosu how about this pr

[dosubot]

This PR looks good overall. It's Part 4 of the systematic isinstance → match/case refactoring initiative tracked in issue #35902 [1], and Parts 1–3 have already been merged, so it's well-aligned with the established direction.

Strengths:

• All four files contain clear isinstance chains that benefit from this conversion [2] [3] [4] [5]
• The PR correctly uses class pattern syntax (case ClassName(): with parentheses), which is the proper way to do type matching in match/case
• Consistent with the existing codebase — 50+ files already use match/case for similar type dispatch patterns [6]
• No functional changes, purely a syntax modernization

One thing to watch:

• The guard clause case dict() if "icon" in provider: is fine but worth a double-check — make sure the match subject and the guard variable reference the same object (i.e., match provider: then case dict() if "icon" in provider: works correctly since provider is the match subject) [7]
• For any subclass relationships in the matched types, ensure cases are ordered from most-specific to least-specific, since match/case stops at the first hit [1]

No red flags — this is a clean, low-risk refactor that follows patterns already approved and merged in earlier parts of this series.

To reply, just mention @dosu.

---

Share context across your team and agents. Try Dosu.

[Copilot]

Pull request overview

This PR refactors several isinstance/elif chains into Python 3.10+ match/case statements to make type-branching logic more declarative and consistent across the codebase.

Changes:

• Refactored provider repacking logic to use match/case for dict/entity/provider variants.
• Refactored datasource parameter value branching (None/str/list/other) to match/case.
• Refactored controller/content type branching in tool label and memory prompt-building code to match/case.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
api/services/tools/tools_transform_service.py	Refactors provider-type branching in repack_provider() using match/case.
api/services/rag_pipeline/rag_pipeline.py	Refactors datasource parameter handling to match/case while preserving assignment behavior.
api/core/tools/tool_label_manager.py	Refactors controller-type branching in get_tool_labels() to match/case.
api/core/memory/token_buffer_memory.py	Refactors prompt content type handling (text/image) to match/case.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.