Skip to content

refactor(web): migrate annotation selection to checkbox group#36370

Merged
lyzno1 merged 3 commits into
mainfrom
codex/migrate-annotation-checkbox-group
May 19, 2026
Merged

refactor(web): migrate annotation selection to checkbox group#36370
lyzno1 merged 3 commits into
mainfrom
codex/migrate-annotation-checkbox-group

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 19, 2026

Summary

  • Migrated the annotation list multi-selection logic to @langgenius/dify-ui/checkbox-group, unifying the header “select all” and row selection states
  • Consolidated the bulk action bar cancel behavior into selection state updates, removing handwritten state branches
  • Adjusted the hover spacing around the annotation config button area to make action button interaction states feel more natural
  • Updated related tests to cover the new selection and cancel behaviors

Testing

  • Added and updated unit tests for the annotation components
  • Verified locally: related tests, type checking, and formatting checks all pass

@lyzno1 lyzno1 requested review from JzoNgKVO and iamjoel as code owners May 19, 2026 04:48
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript refactor labels May 19, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.96%. Comparing base (2d5186f) to head (802e0c0).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
web/app/components/app/annotation/list.tsx 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36370      +/-   ##
==========================================
- Coverage   85.96%   85.96%   -0.01%     
==========================================
  Files        4455     4455              
  Lines      211543   211532      -11     
  Branches    39527    39521       -6     
==========================================
- Hits       181847   181837      -10     
+ Misses      26482    26481       -1     
  Partials     3214     3214              
Flag Coverage Δ
dify-ui 94.59% <ø> (ø)
web 86.55% <94.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 enabled auto-merge May 19, 2026 05:39
@lyzno1 lyzno1 added this pull request to the merge queue May 19, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 19, 2026
Merged via the queue into main with commit 2031d31 May 19, 2026
34 checks passed
@lyzno1 lyzno1 deleted the codex/migrate-annotation-checkbox-group branch May 19, 2026 05:51
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants