Skip to content

refactor(web): migrate multi-checkbox lists to CheckboxGroup#36381

Merged
lyzno1 merged 3 commits into
mainfrom
codex/checkbox-group-cleanup
May 19, 2026
Merged

refactor(web): migrate multi-checkbox lists to CheckboxGroup#36381
lyzno1 merged 3 commits into
mainfrom
codex/checkbox-group-cleanup

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 19, 2026

Summary

  • migrate remaining multi-checkbox segment/filter/label flows to @langgenius/dify-ui CheckboxGroup semantics
  • keep segment selection scoped to the current page CheckboxGroup while preserving selected ids outside the current page
  • update related tests around segment selection, filters, and label selection

Closes #36272

Tests

  • pnpm --dir web test app/components/datasets/documents/detail/completed/hooks/tests/use-segment-selection.spec.ts app/components/datasets/documents/detail/completed/components/tests/menu-bar.spec.tsx app/components/datasets/documents/detail/completed/tests/segment-list.spec.tsx app/components/datasets/documents/detail/completed/components/tests/segment-list-content.spec.tsx app/components/datasets/documents/detail/completed/tests/index.spec.tsx app/components/plugins/plugin-page/filter-management/tests/category-filter.spec.tsx app/components/plugins/plugin-page/filter-management/tests/index.spec.tsx app/components/plugins/marketplace/search-box/tests/tags-filter.spec.tsx app/components/tools/labels/tests/selector.spec.tsx tests/datasets/segment-crud.test.tsx
  • pnpm --dir web type-check

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript refactor labels May 19, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.99%. Comparing base (b04b444) to head (3fb4fdf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36381      +/-   ##
==========================================
- Coverage   85.99%   85.99%   -0.01%     
==========================================
  Files        4458     4458              
  Lines      211918   211893      -25     
  Branches    39544    39531      -13     
==========================================
- Hits       182232   182209      -23     
+ Misses      26471    26469       -2     
  Partials     3215     3215              
Flag Coverage Δ
dify-ui 94.80% <ø> (ø)
web 86.57% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 enabled auto-merge May 19, 2026 07:50
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 19, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 4b2badb May 19, 2026
33 checks passed
@lyzno1 lyzno1 deleted the codex/checkbox-group-cleanup branch May 19, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate multi-checkbox lists to CheckboxGroup

2 participants