Skip to content

chore: hide model provider setting in default model setting#36383

Merged
iamjoel merged 3 commits into
mainfrom
chore/hide-model-provider-setting-in-default-setting
May 19, 2026
Merged

chore: hide model provider setting in default model setting#36383
iamjoel merged 3 commits into
mainfrom
chore/hide-model-provider-setting-in-default-setting

Conversation

@iamjoel
Copy link
Copy Markdown
Contributor

@iamjoel iamjoel commented May 19, 2026

Also improve the copywriting of reasoning model tooltip.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@iamjoel iamjoel requested a review from CodingOnStar as a code owner May 19, 2026 07:59
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. javascript labels May 19, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 19, 2026
lyzno1
lyzno1 previously approved these changes May 19, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.98%. Comparing base (b04b444) to head (7a1f203).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36383      +/-   ##
==========================================
- Coverage   85.99%   85.98%   -0.01%     
==========================================
  Files        4458     4458              
  Lines      211918   211898      -20     
  Branches    39544    39535       -9     
==========================================
- Hits       182232   182211      -21     
- Misses      26471    26472       +1     
  Partials     3215     3215              
Flag Coverage Δ
dify-ui 94.80% <ø> (ø)
web 86.56% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iamjoel iamjoel added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 5276eb6 May 19, 2026
33 checks passed
@iamjoel iamjoel deleted the chore/hide-model-provider-setting-in-default-setting branch May 19, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants