Skip to content

feat(dev-proxy): reload env file changes#36384

Merged
lyzno1 merged 1 commit into
mainfrom
codex/dev-proxy-env-watch
May 19, 2026
Merged

feat(dev-proxy): reload env file changes#36384
lyzno1 merged 1 commit into
mainfrom
codex/dev-proxy-env-watch

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 19, 2026

Summary

  • enable dev-proxy watch mode by default with an opt-out --no-watch flag
  • reload the running proxy when the config file or explicit --env-file changes
  • keep the process stable by swapping the Hono app in place unless host/port changes

Why chokidar

  • c12 watchConfig is the official config-watch path and is used for dev proxy config changes
  • c12 watchConfig does not include the explicit dotenv file passed through --env-file in its watched file list
  • chokidar is c12's documented watcher peer for config watching, so dev-proxy declares it directly and uses it narrowly for the env file instead of relying on an implicit transitive install or an outer process restarter

Test

  • pnpm --config.verify-deps-before-run=false --filter @langgenius/dev-proxy type-check
  • pnpm --config.verify-deps-before-run=false --filter @langgenius/dev-proxy test
  • pnpm --config.verify-deps-before-run=false --filter @langgenius/dev-proxy build

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. javascript labels May 19, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.99%. Comparing base (b04b444) to head (cf9e649).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36384      +/-   ##
==========================================
- Coverage   85.99%   85.99%   -0.01%     
==========================================
  Files        4458     4458              
  Lines      211918   211893      -25     
  Branches    39544    39531      -13     
==========================================
- Hits       182232   182209      -23     
+ Misses      26471    26469       -2     
  Partials     3215     3215              
Flag Coverage Δ
dify-ui 94.80% <ø> (ø)
web 86.57% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 19, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 19, 2026
@lyzno1 lyzno1 removed this pull request from the merge queue due to a manual request May 19, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit a328bbb May 19, 2026
35 checks passed
@lyzno1 lyzno1 deleted the codex/dev-proxy-env-watch branch May 19, 2026 08:32
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants