Skip to content

fix: workflow node selection state not sync caused problem#36390

Merged
lyzno1 merged 4 commits into
mainfrom
fix/workflow-node-selection-state-problem
May 19, 2026
Merged

fix: workflow node selection state not sync caused problem#36390
lyzno1 merged 4 commits into
mainfrom
fix/workflow-node-selection-state-problem

Conversation

@iamjoel
Copy link
Copy Markdown
Contributor

@iamjoel iamjoel commented May 19, 2026

Select the Knowledge Retrieval node and then select other node, sometimes the Knowledge Retrieval node may be selected too.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@iamjoel iamjoel requested a review from zxhlyh as a code owner May 19, 2026 09:58
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. javascript labels May 19, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label May 19, 2026
@iamjoel iamjoel marked this pull request as draft May 19, 2026 10:00
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.99%. Comparing base (cae9923) to head (13899bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #36390   +/-   ##
=======================================
  Coverage   85.98%   85.99%           
=======================================
  Files        4458     4458           
  Lines      211898   211895    -3     
  Branches    39535    39533    -2     
=======================================
- Hits       182210   182209    -1     
+ Misses      26473    26471    -2     
  Partials     3215     3215           
Flag Coverage Δ
dify-ui 94.80% <ø> (ø)
web 86.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

iamjoel added 2 commits May 19, 2026 18:03
…ection-state-problem

# Conflicts:
#	web/app/components/app/configuration/config/agent/agent-tools/index.tsx
@iamjoel iamjoel marked this pull request as ready for review May 19, 2026 10:08
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 19, 2026
@lyzno1 lyzno1 added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 0b48a7e May 19, 2026
33 checks passed
@lyzno1 lyzno1 deleted the fix/workflow-node-selection-state-problem branch May 19, 2026 12:36
zhangtaodemama added a commit to zhangtaodemama/langgenius-dify-bfaadcb0c706 that referenced this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants