fix(offline): guard marketplace I/O paths for ENG-421 [cherry-pick → hotfix/1.14.1-fix.3]#36414
Merged
wylswz merged 1 commit intoMay 20, 2026
Conversation
Skip marketplace fetches, metadata lookups, and bulk-install pre-checks when MARKETPLACE_ENABLED=false. Covers plugin_service, plugin_migration, rag_pipeline, and rag_pipeline_transform_service.
GareArc
requested review from
JohnJyong,
Mairuis,
QuantumGhost,
Stream29,
Yeuoly and
laipz8200
as code owners
dosubot
Bot
added
the
size:M
Contributor
Pyrefly Type Coverage
|
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-05-20 02:22:20.254923764 +0000
+++ /tmp/pyrefly_pr.txt 2026-05-20 02:22:08.004787737 +0000
@@ -587,7 +587,7 @@
ERROR Argument `bool | str | Any` is not assignable to parameter `token` with type `str` in function `core.helper.encrypter.encrypt_token` [bad-argument-type]
--> services/model_load_balancing_service.py:623:71
ERROR `handled_tenant_count` was assigned in the current scope before the nonlocal declaration [unknown-name]
- --> services/plugin/plugin_migration.py:92:34
+ --> services/plugin/plugin_migration.py:93:34
ERROR `dict[str, Any]` is not assignable to attribute `credentials` with type `Never` [bad-assignment]
--> services/trigger/trigger_provider_service.py:487:40
ERROR `int` is not assignable to attribute `credential_expires_at` with type `Never` [bad-assignment]
|
wylswz
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #36335 onto
hotfix/1.14.1-fix.3.MARKETPLACE_ENABLED=falseplugin_service,plugin_migration,rag_pipeline, andrag_pipeline_transform_serviceTest plan
api/tests/unit_tests/services/plugin/,api/tests/unit_tests/services/rag_pipeline/)MARKETPLACE_ENABLED=false