Skip to content

test: stabilize modal context pricing test#36524

Merged
asukaminato0721 merged 1 commit into
langgenius:mainfrom
escape0707:codex/fix-modal-context-pricing-test
May 29, 2026
Merged

test: stabilize modal context pricing test#36524
asukaminato0721 merged 1 commit into
langgenius:mainfrom
escape0707:codex/fix-modal-context-pricing-test

Conversation

@escape0707
Copy link
Copy Markdown
Contributor

@escape0707 escape0707 commented May 22, 2026

Summary

Fixes #36523

Mock the lazy-loaded billing Pricing component in modal-context.test.tsx so the provider test verifies the modal transition without racing the full pricing page dynamic import.

Validation:

  • pnpm -C web test context/modal-context.test.tsx --run
  • pnpm -C web exec eslint context/modal-context.test.tsx --quiet

Screenshots

N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@github-actions github-actions Bot added the web This relates to changes on the web. label May 22, 2026
@escape0707 escape0707 force-pushed the codex/fix-modal-context-pricing-test branch 2 times, most recently from b4eaa88 to c885ad0 Compare May 27, 2026 03:38
@asukaminato0721 asukaminato0721 requested a review from hyoban May 27, 2026 04:53
@escape0707 escape0707 force-pushed the codex/fix-modal-context-pricing-test branch from c885ad0 to d9ccbd6 Compare May 27, 2026 05:04
@escape0707 escape0707 marked this pull request as ready for review May 27, 2026 05:04
@escape0707 escape0707 requested a review from iamjoel as a code owner May 27, 2026 05:04
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. javascript labels May 27, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 29, 2026
@asukaminato0721 asukaminato0721 added this pull request to the merge queue May 29, 2026
Merged via the queue into langgenius:main with commit 78f40c0 May 29, 2026
33 checks passed
@escape0707 escape0707 deleted the codex/fix-modal-context-pricing-test branch May 29, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky ModalContextProvider test races lazy Pricing import

3 participants