Skip to content

feat: snippet new#36617

Merged
FFXN merged 4 commits into
deploy/devfrom
feat/snippet-new
May 25, 2026
Merged

feat: snippet new#36617
FFXN merged 4 commits into
deploy/devfrom
feat/snippet-new

Conversation

@FFXN
Copy link
Copy Markdown
Contributor

@FFXN FFXN commented May 25, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@dosubot dosubot Bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label May 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 25, 2026

Pyrefly Diff

base → PR
--- /tmp/pyrefly_base.txt	2026-05-25 08:35:30.614991549 +0000
+++ /tmp/pyrefly_pr.txt	2026-05-25 08:35:16.666888290 +0000
@@ -26,8 +26,6 @@
    --> controllers/console/snippets/snippet_workflow.py:606:53
 ERROR Returned type `(ParamSpec(P)) -> Response | R` is not assignable to declared return type `(ParamSpec(P)) -> R` [bad-return]
   --> controllers/console/snippets/snippet_workflow_draft_variable.py:77:12
-ERROR Unexpected keyword argument `exclude_node_ids` in function `services.workflow_draft_variable_service.WorkflowDraftVariableService.list_variables_without_values` [unexpected-keyword]
-   --> controllers/console/snippets/snippet_workflow_draft_variable.py:106:17
 ERROR Object of class `MissingRouter` has no attribute `get` [missing-attribute]
   --> controllers/console/version.py:30:2
 ERROR Class member `EasyUIBasedGenerateTaskPipeline._application_generate_entity` overrides parent class `BasedGenerateTaskPipeline` in an inconsistent manner [bad-override-mutable-attribute]

@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 45.55% 45.56% +0.00%
Strict coverage 45.07% 45.07% +0.00%
Typed symbols 23,615 23,616 +1
Untyped symbols 28,527 28,527 0
Modules 2624 2624 0

@FFXN FFXN merged commit d925ed2 into deploy/dev May 25, 2026
4 checks passed
@FFXN FFXN deleted the feat/snippet-new branch May 25, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant