fix: mcp page results shows non mcp tools#36688
Open
prncexe wants to merge 1 commit into
Open
Conversation
Contributor
|
web style check failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #36647.Summary
Fixes #36647. The MCP page's filter logic in
web/app/components/tools/mcp/index.tsxhad a bug where thecollection.type === 'mcp'check was only applied whensearchTextwas empty. When a search term was entered, the filter returned any tool whose name matched, regardless of type — causing non-MCP tools (e.g., built-in tools) to appear in the MCP results. This fix extractsisMcpTypeinto a shared variable so the type constraint is always enforced, even during search.Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods