Skip to content

chore: type check test container tests#36790

Merged
asukaminato0721 merged 1 commit into
langgenius:mainfrom
escape0707:codex/workspace-members-testcontainers
May 29, 2026
Merged

chore: type check test container tests#36790
asukaminato0721 merged 1 commit into
langgenius:mainfrom
escape0707:codex/workspace-members-testcontainers

Conversation

@escape0707
Copy link
Copy Markdown
Contributor

@escape0707 escape0707 commented May 28, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Part of #32454.

Adds a strict Pyrefly config for api/tests/test_containers_integration_tests with a exclude list for currently failing files. The wrapper now runs a second no-target Pyrefly pass for that suite, so clean files stay checked while existing bad files remain isolated.

The suite-specific config enables unannotated-return = true in addition to the strict preset.

Screenshots

N/A

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

Verification run locally:

  • ./dev/pyrefly-check-local
  • blacklist regeneration check from api/tests/test_containers_integration_tests/pyrefly.toml comment

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 28, 2026
@asukaminato0721 asukaminato0721 enabled auto-merge May 29, 2026 01:54
@asukaminato0721 asukaminato0721 added this pull request to the merge queue May 29, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 29, 2026
Merged via the queue into langgenius:main with commit a180ab1 May 29, 2026
30 checks passed
@escape0707 escape0707 deleted the codex/workspace-members-testcontainers branch May 29, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants