fix(api): validate annotation list pagination query#36807
Merged
fatelei merged 2 commits intoMay 29, 2026
Conversation
Contributor
Pyrefly Type Coverage
|
fatelei
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #36805
Validate
GET /v1/apps/annotationsquery parameters with a Pydantic query model instead of relying on Flaskrequest.args.get(..., type=int)fallback behavior.This makes invalid explicit
pageandlimitvalues fail validation instead of silently using defaults, while preserving the existing default pagination values and valid numeric string support. The query model is also used to document Swagger query parameters.Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods