Skip to content

fix: remove unnecessary # type: ignore comments (#24494)#36825

Merged
asukaminato0721 merged 1 commit into
langgenius:mainfrom
EvanYao826:fix/24494-clean-type-ignore
May 29, 2026
Merged

fix: remove unnecessary # type: ignore comments (#24494)#36825
asukaminato0721 merged 1 commit into
langgenius:mainfrom
EvanYao826:fix/24494-clean-type-ignore

Conversation

@EvanYao826
Copy link
Copy Markdown
Contributor

@EvanYao826 EvanYao826 commented May 29, 2026

What

Remove 18 unnecessary # type: ignore comments from commented-out code blocks in dataset_service.py.

#24494

Why

These annotations are inside commented-out code blocks that are never executed. They serve no purpose.

Remove 18 # type: ignore comments from commented-out code blocks in
dataset_service.py. These annotations serve no purpose since the code
is already commented out and not executed.
@EvanYao826 EvanYao826 requested a review from JohnJyong as a code owner May 29, 2026 09:19
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. refactor labels May 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 45.75% 45.75% 0.00%
Strict coverage 45.28% 45.28% 0.00%
Typed symbols 24,633 24,633 0
Untyped symbols 29,512 29,512 0
Modules 2760 2760 0

@asukaminato0721 asukaminato0721 enabled auto-merge May 29, 2026 09:41
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 29, 2026
@asukaminato0721 asukaminato0721 added this pull request to the merge queue May 29, 2026
Merged via the queue into langgenius:main with commit 4872497 May 29, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants