Skip to content

refactor(web): mark workflow run props readonly#36857

Merged
asukaminato0721 merged 1 commit into
langgenius:mainfrom
meaqua9420:refactor-readonly-workflow-props
Jun 1, 2026
Merged

refactor(web): mark workflow run props readonly#36857
asukaminato0721 merged 1 commit into
langgenius:mainfrom
meaqua9420:refactor-readonly-workflow-props

Conversation

@meaqua9420
Copy link
Copy Markdown
Contributor

Summary

  • mark Props fields in workflow run components as readonly
  • keep the change scoped to a small workflow/run slice

Relates to #25219. This is a partial pass and avoids overlapping with the header-only PR #36487.

Tests

  • git diff --check
  • pnpm --dir web exec vp test run app/components/workflow/run/tests/meta.spec.tsx app/components/workflow/run/tests/node.spec.tsx app/components/workflow/run/tests/status-container.spec.tsx app/components/workflow/run/tests/loop-result-panel.spec.tsx app/components/workflow/run/iteration-log/tests/iteration-result-panel.spec.tsx app/components/workflow/run/loop-log/tests/loop-result-panel.spec.tsx app/components/workflow/run/retry-log/tests/retry-result-panel.spec.tsx
  • pnpm --filter dify-web type-check
  • pnpm exec eslint web/app/components/workflow/run/node.tsx web/app/components/workflow/run/meta.tsx web/app/components/workflow/run/status-container.tsx web/app/components/workflow/run/iteration-log/iteration-result-panel.tsx web/app/components/workflow/run/loop-log/loop-result-panel.tsx web/app/components/workflow/run/loop-result-panel.tsx web/app/components/workflow/run/retry-log/retry-result-panel.tsx (0 errors; existing warnings only)

@github-actions github-actions Bot added the web This relates to changes on the web. label May 31, 2026
@meaqua9420 meaqua9420 marked this pull request as ready for review May 31, 2026 07:16
@meaqua9420 meaqua9420 requested review from iamjoel and zxhlyh as code owners May 31, 2026 07:16
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. javascript refactor labels May 31, 2026
@asukaminato0721 asukaminato0721 enabled auto-merge June 1, 2026 04:59
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 1, 2026
@asukaminato0721 asukaminato0721 added this pull request to the merge queue Jun 1, 2026
Merged via the queue into langgenius:main with commit 4a6d278 Jun 1, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:M This PR changes 30-99 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants