chore(cli): move eslint config into cli package#36878
Merged
Merged
Conversation
dosubot
Bot
added
size:M
wylswz
reviewed
Jun 1, 2026
wylswz
approved these changes
Jun 1, 2026
lin-snow
added a commit
to lin-snow/dify
that referenced
this pull request
Jun 1, 2026
The branch's scaffold commit added a `!cli/**` un-ignore plus `cli/context/**`, `cli/docs/**`, `cli/oclif.manifest.json` re-ignores to the root eslint config. These are unused/obsolete: - oclif was removed (langgenius#36328), so `oclif.manifest.json` is never generated. - The CLI has its own `cli/eslint.config.mjs` (langgenius#36878) which already ignores `context/**`, `docs/**`, `dist/**`, `coverage/**`; cli is linted by that config, not the root one. Removing the whole block makes the root ignores identical to upstream/main again. CLI lint coverage is unchanged (verified via `cd cli && pnpm lint`).
lin-snow
added a commit
to lin-snow/dify
that referenced
this pull request
Jun 1, 2026
The branch's scaffold commit added a `!cli/**` un-ignore plus `cli/context/**`, `cli/docs/**`, `cli/oclif.manifest.json` re-ignores to the root eslint config. These are unused/obsolete: - oclif was removed (langgenius#36328), so `oclif.manifest.json` is never generated. - The CLI has its own `cli/eslint.config.mjs` (langgenius#36878) which already ignores `context/**`, `docs/**`, `dist/**`, `coverage/**`; cli is linted by that config, not the root one. Removing the whole block makes the root ignores identical to upstream/main again. CLI lint coverage is unchanged (verified via `cd cli && pnpm lint`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary