Skip to content

fix(web): respect marketplace feature flag in model selector#36883

Merged
lyzno1 merged 1 commit into
mainfrom
codex/fix-model-selector-marketplace-flag
Jun 1, 2026
Merged

fix(web): respect marketplace feature flag in model selector#36883
lyzno1 merged 1 commit into
mainfrom
codex/fix-model-selector-marketplace-flag

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented Jun 1, 2026

Summary

  • read existing system features in the model selector popup and gate marketplace UI on enable_marketplace
  • disable marketplace plugin queries from the model-provider helper when the feature flag is off
  • keep installed/configured models visible while hiding marketplace install prompts and AI-credit marketplace fallbacks

Fixes #36881

Tests

  • pnpm --dir web test app/components/header/account-setting/model-provider-page/tests/hooks.spec.ts app/components/header/account-setting/model-provider-page/model-selector/tests/popup.spec.tsx
  • pnpm --dir web type-check

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. javascript labels Jun 1, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Jun 1, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.82%. Comparing base (240912c) to head (4141704).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...eader/account-setting/model-provider-page/hooks.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #36883      +/-   ##
==========================================
- Coverage   85.82%   85.82%   -0.01%     
==========================================
  Files        4553     4553              
  Lines      222925   222941      +16     
  Branches    41006    41016      +10     
==========================================
+ Hits       191332   191344      +12     
- Misses      27897    27901       +4     
  Partials     3696     3696              
Flag Coverage Δ
dify-ui 95.57% <ø> (ø)
web 86.50% <90.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 enabled auto-merge June 1, 2026 04:02
@lyzno1 lyzno1 changed the title fix: respect marketplace feature flag in model selector fix(web): respect marketplace feature flag in model selector Jun 1, 2026
@lyzno1 lyzno1 added this pull request to the merge queue Jun 1, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 1, 2026
Merged via the queue into main with commit bcd573e Jun 1, 2026
38 checks passed
@lyzno1 lyzno1 deleted the codex/fix-model-selector-marketplace-flag branch June 1, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model selector still shows "From Marketplace" when MARKETPLACE_ENABLED=false / enable_marketplace is false

2 participants