Skip to content

fix(web): defer react-scan loader#36920

Merged
lyzno1 merged 1 commit into
mainfrom
codex/defer-react-scan-loader
Jun 2, 2026
Merged

fix(web): defer react-scan loader#36920
lyzno1 merged 1 commit into
mainfrom
codex/defer-react-scan-loader

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented Jun 2, 2026

Summary

  • defer the dev-only react-scan script until after hydration
  • document that react-scan recommends beforeInteractive, but it can conflict with Dify's inline attribution bootstrap during dev hydration

Tests

  • Not run (per request).

@lyzno1 lyzno1 requested a review from iamjoel as a code owner June 2, 2026 03:27
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. javascript labels Jun 2, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Jun 2, 2026
@lyzno1 lyzno1 enabled auto-merge June 2, 2026 03:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.82%. Comparing base (5c1cfe6) to head (54e820e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #36920   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files        4565     4565           
  Lines      223439   223439           
  Branches    41135    41135           
=======================================
  Hits       191767   191767           
  Misses      27968    27968           
  Partials     3704     3704           
Flag Coverage Δ
dify-ui 95.57% <ø> (ø)
web 86.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 2, 2026
@lyzno1 lyzno1 added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit f465dc5 Jun 2, 2026
37 checks passed
@lyzno1 lyzno1 deleted the codex/defer-react-scan-loader branch June 2, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants