Skip to content

fix(web): use generated account-profile contracts#36927

Merged
lyzno1 merged 12 commits into
mainfrom
feat/account-profile-vertical
Jun 2, 2026
Merged

fix(web): use generated account-profile contracts#36927
lyzno1 merged 12 commits into
mainfrom
feat/account-profile-vertical

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented Jun 2, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

@lyzno1 lyzno1 requested a review from iamjoel as a code owner June 2, 2026 06:26
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. javascript labels Jun 2, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Jun 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

❌ Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.84%. Comparing base (7056985) to head (5258d6c).

Files with missing lines Patch % Lines
web/service/common.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #36927   +/-   ##
=======================================
  Coverage   85.83%   85.84%           
=======================================
  Files        4574     4574           
  Lines      224036   224062   +26     
  Branches    41184    41196   +12     
=======================================
+ Hits       192307   192339   +32     
+ Misses      28010    28004    -6     
  Partials     3719     3719           
Flag Coverage Δ
api 85.35% <100.00%> (ø)
dify-ui 95.57% <ø> (ø)
web 86.49% <97.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 46.03% 46.03% +0.00%
Strict coverage 45.52% 45.52% +0.00%
Typed symbols 24,990 24,991 +1
Untyped symbols 29,629 29,630 +1
Modules 2790 2790 0

@lyzno1 lyzno1 requested review from JzoNgKVO and zhsama as code owners June 2, 2026 06:41
@lyzno1 lyzno1 enabled auto-merge June 2, 2026 06:43
hyoban
hyoban previously approved these changes Jun 2, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 2, 2026
@lyzno1 lyzno1 added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit dea4e66 Jun 2, 2026
41 checks passed
@lyzno1 lyzno1 deleted the feat/account-profile-vertical branch June 2, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants