fix(security): upgrade aiohttp to fix zip bomb and other CVEs#417
fix(security): upgrade aiohttp to fix zip bomb and other CVEs#417Aryansharma28 merged 1 commit intomainfrom
Conversation
Dependency Impact Assessment: aiohttp 3.12.13 → 3.13.51. WHERE IS THIS DEPENDENCY USED?Searched the entire codebase for
2. PRODUCTION CODE IMPACTaiohttp is NOT imported in any production code. The However, aiohttp IS a transitive runtime dependency via 3. EXAMPLES/TESTS/DOCS USAGEAll direct usage is in examples and docs only. The APIs used are:
All of these are foundational aiohttp APIs that have been stable across major versions. None are deprecated or experimental. 4. VERSION JUMP SIZE3.12.13 → 3.13.5 — This is a minor version bump (3.12 → 3.13), not a major version change. Within the 3.x series, aiohttp maintains backward compatibility. The 3.13.x line includes security fixes (the CVEs motivating this PR) and bug fixes. No breaking API changes are expected in a minor bump. 5. PINNED VERSION COMMENTSNone found. Searched the entire codebase for comments mentioning aiohttp with version pins, constraints, or upgrade warnings. No results. 6. TRANSITIVE vs DIRECTTransitive only. aiohttp is NOT listed in The version bump happened because the lockfile was regenerated (likely via 7. OTHER LOCKFILE CHANGESThis PR also bumps several other transitive dependencies in
FINAL VERDICT: LOW RISK ✅Classification: LOW RISK Rationale:
Recommendation: Safe to merge once CI passes. The examples that use aiohttp should continue to work since they only use stable core APIs. If CI includes running the example tests, those will validate compatibility automatically. |
CI Status
Failure AnalysisThe single failure is Evidence this is a known flaky test:
All code-related checks pass. The aiohttp example tests ( Ready for review. |
659f5c8 to
444ff65
Compare
|
Rebased onto latest main. No conflicts. CI re-running. |
444ff65 to
7ebe932
Compare
|
Automated low-risk assessment This PR was evaluated against the repository's Low-Risk Pull Requests procedure and does not qualify as low risk.
This PR requires a manual review before merging. |
Aryansharma28
left a comment
There was a problem hiding this comment.
Reviewed locally: aiohttp 3.12.13 → 3.13.5 is a minor-line bump within the 3.x stable line. Verified 468 unit tests + 207 red-team tests pass on the bumped lockfile. Consumer is litellm (the only direct user of aiohttp), and uv lock --check resolved cleanly proving litellm's pin allows 3.13. CI's full test (3.12) job (6m14s including examples) already passes. Closes multiple high-severity CVEs (#119 zip bomb + others). Pure transitive bump, no source code changes.
Resolves uv.lock conflict (aiohttp 3.13.4 vs 3.13.5 from #417) by re-resolving the lock with litellm>=1.83.14 against current main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Part of #400
Test plan
uv locksucceeds