adds infinite scroll and touch events and dot indicators #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates variable type
Member
|
Im now away from keyboard, gonna review it soon. By the way, can u please run this one as well if you didn't before $ npm run format |
Member
|
Test failed $ npm run check |
Contributor
Author
|
@xuelink I ran npm run format, which runs prettier locally and it updated multiple files. Would you like me to commit those changes to this branch? |
Contributor
Author
|
@xuelink I ran npm run check and I'm not getting any errors now:
|
Contributor
Author
|
@xuelink Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the helpful code, I also added touch events along with dots to indicate which slide is active