[pull] master from mpv-player:master#168
Merged
pull[bot] merged 2 commits intolangyo:masterfrom Jan 23, 2026
Merged
Conversation
Commits 8854c74 and 5ae0e0f eliminated the external swapchain API that the render backend (vo_libmpv) was previously using. However, it was missed that this was being used to skip the gl->FenceSync calls and that logic change was not properly accounted for. This meant that vo_libmpv would leak fences since ra_gl_ctx_swap_buffers is never called to clean them up. Fix this by making sure the ra_ctx_params have swap_buffers defined before calling gl->FenceSync. All platforms are required to implement this anyway with the exception of vo_libmpv since it's a funny special case. Fixes #17217.
We don't allow backends to override this anymore since 5ae0e0f so we can just set it directly in ra_swapchain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )