ENH, TST: Add rtol for ensemble estimators and a test.#45
Merged
tylerjereddy merged 3 commits intomainfrom Feb 4, 2026
Merged
Conversation
Collaborator
|
Thanks for fixing the merge conflicts, I expanded the description a bit more and am reviewing now. |
tylerjereddy
approved these changes
Feb 4, 2026
Collaborator
tylerjereddy
left a comment
tylerjereddy
left a comment
There was a problem hiding this comment.
Yep, this looks excellent too, thanks! The test line coverage looks good and the new regression test looks solid.
I did wonder about potentially reducing duplication in the similar rtol classification tests, but doesn't seem worth the churn for now.
nray
pushed a commit
that referenced
this pull request
Feb 5, 2026
* Related to one of the items in gh-45. As we look toward the publication of our library code, there is value in providing classifier metadata (https://pypi.org/classifiers/) for usage in PyPI releases, for proper indexing/searching, etc. * I've made minor adjustments to the one that SciPy currently uses but we may want to make more changes than what I've done so far: https://github.com/scipy/scipy/blob/main/pyproject.toml#L52
nray
pushed a commit
that referenced
this pull request
Feb 5, 2026
* Related to the addition of docstrings mentioned in gh-45. * This is very much a work in progress for now. It proposes to conform to the numpydoc docstring standard, add a linter for this standard in the CI, and add the first few docstrings. Until more functions/classes are brought up to standard, we expect the CI/doc linting to fail here. * Many more docstrings need to be added of course--feel free to push in some drafts, I'll chip away at them when I can. * This does not yet tackle the task of turning these docstrings into HTML files the public can access, but it is a precursor to that.
nray
pushed a commit
that referenced
this pull request
Feb 5, 2026
* gh-45 discusses the need to provide a release on PyPI for the library code (manuscript), and this patch aims to add testing for the wheel build process and verifying that our testsuite passes via the wheel build route. * Note that this is unlikely to work properly until our `pyproject.toml` has been appropriately updated to specify all necessary dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BUG, ENH: Discrepancy between GrafoRVFL and RVFLRegressor for MoorePenrose Solver #12.
Adds an
rtolargument toEnsembleGFDLClassifierso that the user may control the singular value cutoff when using the Moore-Penrose solver. Without this option, the user would not be able to achieve reasonable estimator performance on many design matrices when using Moore-Penrose.