Skip to content

Kokkos 5#30

Merged
RyanWollaeger merged 11 commits into
developfrom
dempsey/kokkos5
May 19, 2026
Merged

Kokkos 5#30
RyanWollaeger merged 11 commits into
developfrom
dempsey/kokkos5

Conversation

@adamdempsey90
Copy link
Copy Markdown
Collaborator

@adamdempsey90 adamdempsey90 commented Apr 25, 2026

Background

Updates all the submodules to the latest. This puts us on Kokkos 5 and C++20. Also turned off a kokkos cmake option that was causing segfaults on Tuolumne.

Description of Changes

  • [ ]

Checklist

  • New features are documented
  • Tests added for bug fixes and new features
  • (@lanl.gov employees) Update copyright on changed files

@adamdempsey90
Copy link
Copy Markdown
Collaborator Author

Can we get this merged @pdmullen , @RyanWollaeger

Copy link
Copy Markdown
Collaborator

@RyanWollaeger RyanWollaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanWollaeger
Copy link
Copy Markdown
Collaborator

Will plan to merge once the GPU CI is done, unless @pdmullen has comments.

@RyanWollaeger
Copy link
Copy Markdown
Collaborator

@adamdempsey90 are there any changes needed to env/bash to get the GPU working (see my MG DDMCD PR for instance - some of the volta changes from that may be needed here)?

@adamdempsey90
Copy link
Copy Markdown
Collaborator Author

@adamdempsey90 are there any changes needed to env/bash to get the GPU working (see my MG DDMCD PR for instance - some of the volta changes from that may be needed here)?

Added

@adamdempsey90 adamdempsey90 requested a review from pdmullen May 11, 2026 18:21
@adamdempsey90
Copy link
Copy Markdown
Collaborator Author

There's something wrong with the darwin CI...

@adamdempsey90
Copy link
Copy Markdown
Collaborator Author

There's something wrong with the darwin CI...

Compiler needs to be updated

@RyanWollaeger
Copy link
Copy Markdown
Collaborator

There's something wrong with the darwin CI...

Compiler needs to be updated

Yeah - this is what I was referring to

@adamdempsey90
Copy link
Copy Markdown
Collaborator Author

There's something wrong with the darwin CI...

Compiler needs to be updated

Yeah - this is what I was referring to

I thought you were talking about the elcap piece of env/bash

@RyanWollaeger
Copy link
Copy Markdown
Collaborator

There's something wrong with the darwin CI...

Compiler needs to be updated

Yeah - this is what I was referring to

I thought you were talking about the elcap piece of env/bash

Ah - sorry - I didn't mention the CI initially... sort of a critical detail here - useful to have the elcap settings here too.

Comment thread CMakeLists.txt Outdated
@adamdempsey90
Copy link
Copy Markdown
Collaborator Author

Fully updated parthenon. Tests pass. Ready to merge @RyanWollaeger @pdmullen ?

@RyanWollaeger RyanWollaeger merged commit 1320212 into develop May 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants