Ensure FixedT and FixedP PTE solvers use sensible uscale
#568
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The
FixedTandFixedPPTE solvers were adding the weighteed component energies from the initial density guess to generate a characteristic scale for the energy and pressure. However, this wasn't hardened against the possibility that the energies could be negative, which would cause the solver to diverge in the opposite direction of a solution.This PR uses an absolute value of the energy for the
FixedTsolver and and absolute value of the input pressure for theFixedPsolver.This functionality is essentially tested in the
MultiEOSMR, so I won't add a test here.PR Checklist
make formatcommand after configuring withcmake.If preparing for a new release, in addition please check the following:
when='@main'dependencies are updated to the release version in the package.py