Skip to content

Conversation

@jhp-lanl
Copy link
Collaborator

@jhp-lanl jhp-lanl commented Sep 25, 2025

PR Summary

This simplifies the process of turning on/off address sanitizing.

It turns out that sesame2spiner with address sanitizing tends to run out of virtual memory pretty easily, so it's nice to build that without sanitizing, run it, and then build the rest of the code with sanitizing. A CMake option makes this a lot easier.

This is an advanced option, especially since it has PUBLIC scope to better reach all our executables. It's really just for testing.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • N/A Format your changes by using the make format command after configuring with cmake.
  • N/A Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@jhp-lanl
Copy link
Collaborator Author

Still testing to make sure it works as intended...

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@jhp-lanl jhp-lanl merged commit 3d9b009 into main Sep 25, 2025
9 checks passed
@jhp-lanl jhp-lanl deleted the jhp/cmake_sanitize branch September 25, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants