Skip to content

Conversation

@jhp-lanl
Copy link
Collaborator

@jhp-lanl jhp-lanl commented Oct 24, 2025

PR Summary

This PR changes the PTE solver base class to accomodate EOS models whose preferred inputs include pressure. In this case, a lookup won't be performed to get the initial pressure for the PTE solver and instead the provided pressure for this material will be used.

Fixes #581

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, which I think should be addressed before merge (and tests should pass) but I'm approving now.

@Yurlungur Yurlungur added the bug Something isn't working label Oct 24, 2025
@jhp-lanl
Copy link
Collaborator Author

Let's make sure the LANL tests pass before we merge this

@Yurlungur
Copy link
Collaborator

Let's make sure the LANL tests pass before we merge this

👍 yep definitely

@jhp-lanl
Copy link
Collaborator Author

Tests pass

@jhp-lanl jhp-lanl merged commit 36dee9c into main Oct 24, 2025
9 checks passed
@jhp-lanl jhp-lanl deleted the jhp/PTpreferred branch October 24, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetPressureFromPreferred() in the PTE solver base class should handle P-T preferred

3 participants