Skip to content

add macaddr to device identifiers#20

Merged
lanrat merged 1 commit intolanrat:mainfrom
elratt0r:add_macaddr_to_identifiers
Dec 11, 2022
Merged

add macaddr to device identifiers#20
lanrat merged 1 commit intolanrat:mainfrom
elratt0r:add_macaddr_to_identifiers

Conversation

@elratt0r
Copy link
Copy Markdown
Contributor

reintroduce identifier reverted in 56071c8. needed to increment buffer size to hold full serialized mqtt string

@lanrat
Copy link
Copy Markdown
Owner

lanrat commented Dec 11, 2022

Thanks for fixing my failed attempt!

@lanrat lanrat merged commit 1bf8313 into lanrat:main Dec 11, 2022
@elratt0r
Copy link
Copy Markdown
Contributor Author

You're welcome :-) I had it in a branch already, but put it aside because of the memory leaks coming from the doc.clean(). Took me some time to dive into ArduinoJson docs to understand the behavior.

@elratt0r elratt0r deleted the add_macaddr_to_identifiers branch April 2, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants