Fix expander i2c address and touchpad issues#24
Merged
lanrat merged 4 commits intolanrat:mainfrom Apr 3, 2023
Merged
Conversation
Owner
|
Thanks for the PR for adding better support for the Inkplate10v2! However, after testing, I still have the touchpad sensitivity issue, especially when on USB power. |
Contributor
Author
|
Thx 4 merging. I wonder about this sensivity issue, because there is no code involved in calibrating them. They're connected via their converter ic's directly to the expander. Did you do a "--target clean"? I had problems with the expander functions when rebuilding until I cleaned up the build and the library cache. |
Owner
|
Thanks for that clean suggestion. That seemed to work on my device, so I added the suggestion to the README as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP23017_INTFA is the register address, not the i2c bus addr. Using the newly introduced IO_INT_ADDR resolved also the touchpad sensivity problem mentioned in 6e512f7. In main.c I made use of the library exposed function that leaves out dealing with the expander addresses completely.
(I am right now testing how this can also be incorporated in the checkBootPads - I will get a inkplate10v2 soon and that has a different expander chip)