Drawing text only paints bounding boxes

[zhaojiangbin]

Since this commit 4abb0fa that switched to opengl backend.

Tested the debug build. Didn't have time for release build.

It compiles but almost all text become "blocks" in the UI, like below:

The machine info:

[zhaojiangbin]

@bugadani, @dzhou121, Can we disable opengl in master until it's properly fixed? Or even if it is only disabled for macOS for now?

With this change, debug build on macOS works again:

diff --git a/lapce-data/Cargo.toml b/lapce-data/Cargo.toml
index 6c5d861..b4fdaa0 100644
--- a/lapce-data/Cargo.toml
+++ b/lapce-data/Cargo.toml
@@ -47,7 +47,7 @@ xi-unicode = "0.3.0"
 fuzzy-matcher = "0.3.7"
 uuid = { version = "0.8.2", features = ["v4"] }
 lsp-types = { version = "0.89.2", features = ["proposed"] }
-druid = { git = "https://github.com/lapce/druid", branch = "opengl", features = [ "svg", "im", "serde", ] }
+druid = { git = "https://github.com/lapce/druid", features = [ "svg", "im", "serde", ] }
 # druid = { path = "../../druid/druid", features = ["svg", "im" , "serde"] }
 toml = { version = "0.5.8", features = ["preserve_order"] }
 structdesc = { git = "https://github.com/lapce/structdesc" }
diff --git a/lapce-ui/Cargo.toml b/lapce-ui/Cargo.toml
index cfed13b..3a26772 100644
--- a/lapce-ui/Cargo.toml
+++ b/lapce-ui/Cargo.toml
@@ -43,7 +43,7 @@ xi-rope = { git = "https://github.com/lapce/xi-editor", features = ["serde"] }
 xi-unicode = "0.3.0"
 fuzzy-matcher = "0.3.7"
 lsp-types = { version = "0.89.2", features = ["proposed"] }
-druid = { git = "https://github.com/lapce/druid", branch = "opengl", features = [ "svg", "im", "serde", ] }
+druid = { git = "https://github.com/lapce/druid", features = [ "svg", "im", "serde", ] }
 # druid = { path = "../../druid/druid", features = ["svg", "im" , "serde"] }
 toml = { version = "0.5.8", features = ["preserve_order"] }
 structdesc = { git = "https://github.com/lapce/structdesc" }

I cannot figure out a way to disable opengl only for target_os = "macos". The following change does not work:

diff --git a/lapce-data/Cargo.toml b/lapce-data/Cargo.toml
index b4fdaa0..a49b6e6 100644
--- a/lapce-data/Cargo.toml
+++ b/lapce-data/Cargo.toml
@@ -47,7 +47,6 @@ xi-unicode = "0.3.0"
 fuzzy-matcher = "0.3.7"
 uuid = { version = "0.8.2", features = ["v4"] }
 lsp-types = { version = "0.89.2", features = ["proposed"] }
-druid = { git = "https://github.com/lapce/druid", features = [ "svg", "im", "serde", ] }
 # druid = { path = "../../druid/druid", features = ["svg", "im" , "serde"] }
 toml = { version = "0.5.8", features = ["preserve_order"] }
 structdesc = { git = "https://github.com/lapce/structdesc" }
@@ -57,6 +56,12 @@ lapce-rpc = { path = "../lapce-rpc" }
 lapce-proxy = { path = "../lapce-proxy" }
 bytemuck = "1.8.0"

+[target.'cfg(target_os = "macos")'.dependencies]
+druid = { git = "https://github.com/lapce/druid", features = [ "svg", "im", "serde", ] }
+
+[target.'cfg(not(target_os = "macos"))'.dependencies]
+druid = { git = "https://github.com/lapce/druid", branch = "opengl", features = [ "svg", "im", "serde", ] }
+
 [build-dependencies]
 cc = "1"
 anyhow = "1.0.32"
diff --git a/lapce-ui/Cargo.toml b/lapce-ui/Cargo.toml
index 3a26772..605f580 100644
--- a/lapce-ui/Cargo.toml
+++ b/lapce-ui/Cargo.toml
@@ -43,13 +43,18 @@ xi-rope = { git = "https://github.com/lapce/xi-editor", features = ["serde"] }
 xi-unicode = "0.3.0"
 fuzzy-matcher = "0.3.7"
 lsp-types = { version = "0.89.2", features = ["proposed"] }
-druid = { git = "https://github.com/lapce/druid", features = [ "svg", "im", "serde", ] }
 # druid = { path = "../../druid/druid", features = ["svg", "im" , "serde"] }
 toml = { version = "0.5.8", features = ["preserve_order"] }
 structdesc = { git = "https://github.com/lapce/structdesc" }
 lapce-data = { path = "../lapce-data" }
 lapce-rpc = { path = "../lapce-rpc" }

+[target.'cfg(target_os = "macos")'.dependencies]
+druid = { git = "https://github.com/lapce/druid", features = [ "svg", "im", "serde", ] }
+
+[target.'cfg(not(target_os = "macos"))'.dependencies]
+druid = { git = "https://github.com/lapce/druid", branch = "opengl", features = [ "svg", "im", "serde", ] }
+
 [build-dependencies]
 cc = "1"
 anyhow = "1.0.32"

$ cargo b
error: failed to load manifest for workspace member `/Users/jzhao/rust/lapce/lapce-ui`

Caused by:
  failed to parse manifest at `/Users/jzhao/rust/lapce/lapce-ui/Cargo.toml`

Caused by:
  Dependency 'druid' has different source paths depending on the build target. Each dependency must have a single canonical source path irrespective of build target.

[bugadani]

I think it's a reasonable proposal, given how opengl looks at the moment. Opengl development could happen on a different thread and be merged once it's ready, without blocking potential contributions. And if someone has more trouble with wgpu, they can base their pull requests on top of the opengl branch for the time being, for development. I expect most PRs submitted that way could just as easily be rebased on top on master instead so I don't expect the opengl branch to contain lots of unreleased features, splitting the development in two.

But this is not up to me :)

[bugadani]

@zhaojiangbin maybe you could import druid on macos using a different package name, but that would also need some code changes in lapce. I don't think a platform-dependent dependency is a good solution, especially since we have issues not just on macos.

[zhaojiangbin]

I agree. If it requires code change, it's not a good approach.

[uael]

It's not macos related, same on linux here

EDIT: I confirm that not using the opengl branch fixed the font rendering on linux too

[univerz]

btw, someone made this PR which should fix piet-wgpu on linux => another point for wgpu

[maxwell8888]

I have the same problem on Ubuntu

[dzhou121]

Can you please try to run this

https://github.com/dfrg/swash_demo

to see if it has the same issue?

[maxwell8888]

Can you please try to run this

https://github.com/dfrg/swash_demo

to see if it has the same issue?

The demo runs fine for me, no issue.

[zhaojiangbin]

The demo works fine on my macbook. For what it's worth, it output the following on stdout:

Pixel format of the window's GL context: PixelFormat { hardware_accelerated: true, color_bits: 24, alpha_bits: 8, depth_bits: 24, stencil_bits: 8, stereoscopy: false, double_buffer: true, multisampling: None, srgb: true }
OpenGL version 4.1 ATI-4.6.21
Evicted 0