Log panics with full backtrace as errors#1404
Merged
dzhou121 merged 2 commits intolapce:masterfrom Sep 30, 2022
Merged
Conversation
bugadani
added
A-dev
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## master #1404 +/- ##
=========================================
- Coverage 6.17% 6.17% -0.01%
=========================================
Files 122 122
Lines 48925 48992 +67
=========================================
Hits 3023 3023
- Misses 45902 45969 +67
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR captures and logs panics as errors. No backtrace is captured right now but it can be enabled using the
with-backtracefeature flag and some configuring on the log-panic side.