feat(lsp): add 'codeAction/resolve' support#1420
Merged
dzhou121 merged 1 commit intolapce:masterfrom Oct 3, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1420 +/- ##
=========================================
+ Coverage 6.15% 6.18% +0.02%
=========================================
Files 122 122
Lines 49420 49195 -225
=========================================
Hits 3041 3041
+ Misses 46379 46154 -225
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
oknozor
force-pushed
the
feat/codeAction/resolve
branch
from
ce84f21 to
a2ed6a9
Compare
dzhou121
reviewed
Oct 2, 2022
lapce-proxy/src/plugin/mod.rs
Outdated
| cb: impl FnOnce(Result<CodeAction, RpcError>) + Send + Clone + 'static, | ||
| ) { | ||
| let method = CodeActionResolveRequest::METHOD; | ||
| self.send_request_to_all_plugins( |
Collaborator
There was a problem hiding this comment.
It would be better to include the plugin_id in the code action response, and then only send to the same plugin_id here.
oknozor
force-pushed
the
feat/codeAction/resolve
branch
from
a2ed6a9 to
f5c3f69
Compare
oknozor
force-pushed
the
feat/codeAction/resolve
branch
from
f5c3f69 to
241e7e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for lsp
codeAction/resolve(see: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_codeAction)