Skip to content

Fix multiple cursor offset after inserting opening pair#1423

Merged
dzhou121 merged 2 commits intolapce:masterfrom
NiceSieve:pair-offset
Oct 1, 2022
Merged

Fix multiple cursor offset after inserting opening pair#1423
dzhou121 merged 2 commits intolapce:masterfrom
NiceSieve:pair-offset

Conversation

@NiceSieve
Copy link
Copy Markdown
Contributor

Code was editing the region before comparing it to the previously inserted region.
Also add doc to matching_pair_direction function.

This closes #1374

also add doc to matching_pair_direction function
@NiceSieve
Copy link
Copy Markdown
Contributor Author

Am writing a regression test right now, just want the CI checks in parallel :)

@NiceSieve NiceSieve marked this pull request as ready for review October 1, 2022 17:02
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #1423 (c16cf5a) into master (3ce1306) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           master   #1423      +/-   ##
=========================================
+ Coverage    6.10%   6.16%   +0.06%     
=========================================
  Files         122     122              
  Lines       49317   49289      -28     
=========================================
+ Hits         3013    3041      +28     
+ Misses      46304   46248      -56     
Impacted Files Coverage Δ
lapce-core/src/syntax/util.rs 20.28% <ø> (+2.89%) ⬆️
lapce-core/src/editor.rs 29.86% <100.00%> (+1.45%) ⬆️
lapce-data/src/proxy.rs 0.00% <0.00%> (ø)
lapce-data/src/update.rs 0.00% <0.00%> (ø)
lapce-proxy/src/plugin/lsp.rs 0.00% <0.00%> (ø)
lapce-core/src/cursor.rs 5.54% <0.00%> (+0.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dzhou121 dzhou121 merged commit 7463874 into lapce:master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-cursor with insertion of parentheses moves to wrong cursor position

3 participants