Skip to content

Trim whitespace from search results#1453

Merged
dzhou121 merged 4 commits intolapce:masterfrom
camc314:cam/dev/trim-search-result
Oct 11, 2022
Merged

Trim whitespace from search results#1453
dzhou121 merged 4 commits intolapce:masterfrom
camc314:cam/dev/trim-search-result

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Oct 7, 2022

After:
Screenshot 2022-10-07 at 20 16 16

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #1453 (61c2ce9) into master (7c993f9) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head 61c2ce9 differs from pull request most recent head 60f2686. Consider uploading reports for the commit 60f2686 to get more accurate results

@@            Coverage Diff            @@
##           master   #1453      +/-   ##
=========================================
- Coverage    6.10%   6.04%   -0.06%     
=========================================
  Files         123     124       +1     
  Lines       49822   50878    +1056     
=========================================
+ Hits         3041    3077      +36     
- Misses      46781   47801    +1020     
Impacted Files Coverage Δ
lapce-data/src/config.rs 0.00% <0.00%> (ø)
lapce-ui/src/search.rs 0.00% <0.00%> (ø)
lapce-core/src/buffer/mod.rs 63.06% <0.00%> (-0.21%) ⬇️
lapce-proxy/src/lib.rs 0.69% <0.00%> (-0.03%) ⬇️
lapce-ui/src/app.rs 0.00% <0.00%> (ø)
lapce-ui/src/tab.rs 0.00% <0.00%> (ø)
lapce-ui/src/find.rs 0.00% <0.00%> (ø)
lapce-ui/src/list.rs 0.00% <0.00%> (ø)
lapce-rpc/src/core.rs 0.00% <0.00%> (ø)
lapce-ui/src/hover.rs 0.00% <0.00%> (ø)
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dzhou121
Copy link
Copy Markdown
Collaborator

The matching hightlight isn't correct any more.

Also I think it's best to be an option.

@camc314
Copy link
Copy Markdown
Contributor Author

camc314 commented Oct 10, 2022

Thanks for reviewing! I've added a config setting for it + fixed the highlighting

@camc314
Copy link
Copy Markdown
Contributor Author

camc314 commented Oct 10, 2022

Screenshot 2022-10-10 at 21 01 42

@dzhou121 dzhou121 merged commit 5ee29b9 into lapce:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants