Conversation
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
=========================================
- Coverage 6.64% 6.56% -0.09%
=========================================
Files 126 127 +1
Lines 53284 53944 +660
=========================================
Hits 3541 3541
- Misses 49743 50403 +660
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif this change could be valuable to usersThis PR adds support for displaying the signature of a function when it is being called, by asking the language server for the information.
It binds this to Ctrl+Shift+Space, since that is a common binding for showing it when it is closed.
Notes:
get_signaturekeybinding in bothkeymaps-macos.tomlandkeymaps-nonmacos.toml, but they are the same. I did that due to get_completion being defined in both, but is that really intended? Shouldn't it just be inkeymaps-common.toml?