Display the keybinding of a command within the palette#1723
Merged
Conversation
MinusGix
force-pushed
the
palette-command-keybind
branch
from
3e52764 to
00b21b3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1723 +/- ##
=========================================
- Coverage 6.56% 6.55% -0.02%
=========================================
Files 127 127
Lines 53944 54039 +95
=========================================
Hits 3541 3541
- Misses 50403 50498 +95
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
|
Would you mind changing it to be painted at the end of the line and in this style https://github.com/lapce/lapce/blob/master/lapce-data/src/keypress/mod.rs#L45 |
MinusGix
force-pushed
the
palette-command-keybind
branch
from
00b21b3 to
e801728
Compare
MinusGix
force-pushed
the
palette-command-keybind
branch
from
e801728 to
8856131
Compare
Member
Author
|
Okay, I've made them right aligned and using the same style as the keymaps. |
|
Also fixes #1391 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif this change could be valuable to usersThis PR adds the keybinding for a command as the hint in the palette. Fixes #1683. This will make it easier for users to know the keybinding for a command they might be using often.
It pays attention to what mode the user is in, so it won't recommend completely incorrect keybinds.
Could be improved with some better alignment of the keybindings?
I think this could also be improved by taking into account
whenthe keybind can be used.