Use file path comparison which normalises drive letters for code actions#643
Merged
dzhou121 merged 1 commit intolapce:masterfrom Jun 19, 2022
Merged
Use file path comparison which normalises drive letters for code actions#643dzhou121 merged 1 commit intolapce:masterfrom
dzhou121 merged 1 commit intolapce:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the rust-url crate doesn't handle windows drive letters. Compare to e.g. vscode-uri, which does do this normalisation.
Note that our handling of cross-drive paths is not very robust, so we need to consider what assumptions are made about paths being on the host. (Since at the moment, code actions are run in the client rather than in the proxy)
However, this strictly improves the situation for current usage.