Handle LSP requests for hearing about file saving of specific files#744
Merged
dzhou121 merged 1 commit intolapce:masterfrom Jul 5, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the LSP only sends
didSaveevents when the file's language id matches the LSP's language id.For LSPs like Rust-Analyzer, they also handle that event for other documents. For RA, it wants to hear about
Cargo.tomlandCargo.lockspecifically; so that it can update based on the changed results. While it will get the changed values the next time the user saves a Rust file, this isn't as good as it could be.This just tells the LSP that we are willing to hear dynamic registration of what files it wants to hear updates about. The LSP protocol has these defined as globs, so I use the
globsetcrate to match against those (which we already depended on through another dependency).Currently it keeps the code for sending the updates to the client if their language id's match, though I'm unsure if that's the way the LSP spec wants that set up?