Merged
Conversation
Contributor
Author
|
I've created a new commit to fix fmt and clippy warnings. Two commits are rebased for better git history. |
Collaborator
|
You can simply wrap LapceScroll on Plugin itself I think. |
Contributor
Author
Theoretically yes but I don't know how to do it elegantly. So I imitate what file explorer did, using a wrapper to add LapceScroll to the plugin list. |
Collaborator
|
Something like this |
Contributor
Author
|
Thank you for your advice, I'll update the PR accordingly. |
fix clippy and fmt warnings code cleanup
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix #779
Use
LapceScrollto wrap the originalPlugincomponent.