Specify the workspace folder of the root uri if available#849
Merged
dzhou121 merged 1 commit intolapce:masterfrom Jul 22, 2022
Merged
Specify the workspace folder of the root uri if available#849dzhou121 merged 1 commit intolapce:masterfrom
dzhou121 merged 1 commit intolapce:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
root_uriis deprecated, and so we should specify workspace folder as well (if we can). I don't think there's any LSPs that actually require it currently, but it might be useful in the future.Note: I was a bit uncertain about the name of the workspace passed to the LSP. At a glance I didn't nice function on
Urlto get the basename, and I'm not sure it matters much beyond the case of if an LSP decides to use it in an error message?