Merged
Conversation
Contributor
Author
|
This works on Windows and Mac, but I'm open to discussing if some other implementation would be better. |
db526c7 to
b1b4c9a
Compare
On Mac when a character is pressed along with shift and command, the character returned is not the upper case variant. This code allows recognition of "Redo", command- shift-z, to work.
Contributor
Author
|
I cleaned up the implementation a bit, now it is really ready for testing/review. |
panekj
pushed a commit
to panekj/lapce
that referenced
this pull request
Aug 7, 2022
On Mac when a character is pressed along with shift and command, the character returned is not the upper case variant. This code allows recognition of "Redo", command- shift-z, to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Mac when a character is pressed along with shift and
command, the character returned is not the upper case
variant. This code allows recognition of "Redo", command-
shift-z, to work.