Skip to content

Fix hotkey for redo#914

Merged
dzhou121 merged 1 commit intolapce:masterfrom
rtsuk:mod_shift
Aug 2, 2022
Merged

Fix hotkey for redo#914
dzhou121 merged 1 commit intolapce:masterfrom
rtsuk:mod_shift

Conversation

@rtsuk
Copy link
Copy Markdown
Contributor

@rtsuk rtsuk commented Aug 1, 2022

On Mac when a character is pressed along with shift and
command, the character returned is not the upper case
variant. This code allows recognition of "Redo", command-
shift-z, to work.

@MinusGix MinusGix added C-bug Category: bug - something isn't working as it's supposed to P-macos This issue affects MacOS users A-keymap Area: default key bindings labels Aug 1, 2022
@rtsuk
Copy link
Copy Markdown
Contributor Author

rtsuk commented Aug 2, 2022

This works on Windows and Mac, but I'm open to discussing if some other implementation would be better.

@rtsuk rtsuk force-pushed the mod_shift branch 2 times, most recently from db526c7 to b1b4c9a Compare August 2, 2022 14:08
On Mac when a character is pressed along with shift and
command, the character returned is not the upper case
variant.  This code allows recognition of "Redo", command-
shift-z, to work.
@rtsuk
Copy link
Copy Markdown
Contributor Author

rtsuk commented Aug 2, 2022

I cleaned up the implementation a bit, now it is really ready for testing/review.

@dzhou121 dzhou121 merged commit 1449611 into lapce:master Aug 2, 2022
@rtsuk rtsuk deleted the mod_shift branch August 2, 2022 18:28
panekj pushed a commit to panekj/lapce that referenced this pull request Aug 7, 2022
On Mac when a character is pressed along with shift and
command, the character returned is not the upper case
variant.  This code allows recognition of "Redo", command-
shift-z, to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-keymap Area: default key bindings C-bug Category: bug - something isn't working as it's supposed to P-macos This issue affects MacOS users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants