Skip to content

Conversation

@marktopper
Copy link
Member

@marktopper marktopper commented Feb 2, 2018

Thanks to @emptynick for reporting this issue.

@marktopper marktopper merged commit 6b3ce66 into master Feb 2, 2018
@marktopper marktopper deleted the bugfix/support-window-separator branch February 2, 2018 13:16
@fletch3555
Copy link
Member

A little late since this is already merged, but doesn't PHP have a constant that holds the current environment's directory separator? You could simplify it and use that

@marktopper
Copy link
Member Author

Properly a good idea @fletch3555. 👍

@emptynick
Copy link
Collaborator

It does, but $path holds something like \hooks/test-hook/resources\assets\scripts\alert.js in my case.

@fletch3555
Copy link
Member

Yeah, I had a feeling that might be the case. But $file->getRelativePath() shouldn't do that... I think it should always return a valid path using on your current file system separator. Might be worth digging into that and reporting it on the repo for whatever that's coming from (Flysystem?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants