[FEATURE] Add support for multiple cache implementations, separating result, query and metadata caching. #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickbrouwers
requested changes
Jan 25, 2017
| $this->setSecondLevelCaching($configuration); | ||
| } | ||
|
|
||
| private function applyNamedCacheConfiguration($cacheName) |
src/EntityManagerFactory.php
Outdated
| $defaultDriver = $this->config->get('doctrine.cache.default', $this->defaultCache['type']); | ||
| $defaultNamespace = $this->config->get('doctrine.cache.namespace', $this->defaultCache['namespace']); | ||
|
|
||
| $driverType = $this->config->get('doctrine.cache.' . $cacheName . '.type', $defaultDriver); |
Contributor
There was a problem hiding this comment.
type should be named driver
…rs and second level caching
Also added some docblock comments
BrandonLegault
force-pushed
the
feature-multicaching
branch
from
1193e9e to
74bb417
Compare
Contributor
Author
|
I added the requested changes... I also rebased from 1.2 to keep my branch up to date. I'd already made the changes before I saw the DOCTRINE_CACHE env variable comment. I made them take on new env variables. Do you want me to change that? |
patrickbrouwers
requested changes
Jan 25, 2017
| 'second_level' => false, | ||
| 'cache' => [ | ||
| 'second_level' => false, | ||
| 'default' => 'array', |
Contributor
There was a problem hiding this comment.
'default' => env('DOCTRINE_CACHE', 'array'),
| $defaultDriver = $this->config->get('doctrine.cache.default', $this->defaultCache['type']); | ||
| $defaultNamespace = $this->config->get('doctrine.cache.namespace', $this->defaultCache['namespace']); | ||
|
|
||
| $driver = $this->config->get('doctrine.cache.' . $cacheName . '.driver', $defaultDriver); |
Contributor
There was a problem hiding this comment.
$cache = $this->cache->driver($driver);
if ($namespace = $this->config->get('doctrine.cache.' . $cacheName . '.namespace', $defaultNamespace)) {
$cache->setNamespace($namespace);
}
return $cache;| */ | ||
| private function applyNamedCacheConfiguration($cacheName) | ||
| { | ||
| $defaultDriver = $this->config->get('doctrine.cache.default', $this->defaultCache['type']); |
Contributor
There was a problem hiding this comment.
Replace $this->defaultCache['type'] by 'array'
Remove $this->defaultCache['namespace']
|
|
||
| /** | ||
| * @var array | ||
| */ |
Contributor
No it's fine. |
patrickbrouwers
approved these changes
Jan 29, 2017
patrickbrouwers
pushed a commit
that referenced
this pull request
Feb 21, 2017
If you have memcached or redis extensions installed doctrine will try to automatically connect to one of them if no cache paramter is set when dev mode is off. Defaulting to the default driver to prevent that behavior from occuring. Signed-off-by: RJ Garcia <rj@bighead.net>
patrickbrouwers
added a commit
that referenced
this pull request
Feb 21, 2017
If you have memcached or redis extensions installed doctrine will try to automatically connect to one of them if no cache paramter is set when dev mode is off. Defaulting to the default driver to prevent that behavior from occuring. Signed-off-by: RJ Garcia <rj@bighead.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure a different cache driver for each of metadata, result and query caching through the
doctrine.phpconfig file'cache'array.Changes proposed in this pull request:
The current cache array format is as follows:
This branch introduces this format:
The configuration is currently applied in this PR by calling
\Doctrine\ORM\Configuration->set[Result|Query|Metadata]CacheImplafter reading the values from the config.The
defaultcache array entries remain the same to ensure backwards compatibility. If any of the metadata, result or query entries are missing from the configuration then they will take whichever the default entry is. The default entry is also mirrored/stored directly in code in case it's accidentally deleted from the configuration.