[FIX] Fixing default caching bug introduced from #205 #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragboyjr
changed the title
patrickbrouwers
requested changes
Feb 19, 2017
src/EntityManagerFactory.php
Outdated
| array_get($settings, 'dev', false), | ||
| array_get($settings, 'proxies.path') | ||
| array_get($settings, 'proxies.path'), | ||
| new ArrayCache() |
Contributor
There was a problem hiding this comment.
It's probably best to get the actual default cache driver then:
$defaultDriver = $this->config->get('doctrine.cache.default', 'array');
$this->cache->driver($driver);
If you have memcached or redis extensions installed doctrine will try to automatically connect to one of them if no cache paramter is set when dev mode is off. Defaulting to the default driver to prevent that behavior from occuring. Signed-off-by: RJ Garcia <rj@bighead.net>
Contributor
Author
|
@patrickbrouwers no problem, can you check now? |
|
i have the same problem. Please add this line into EntityFactoryManager: |
patrickbrouwers
added a commit
that referenced
this pull request
Feb 21, 2017
If you have memcached or redis extensions installed doctrine will try to automatically connect to one of them if no cache paramter is set when dev mode is off. Defaulting to the default driver to prevent that behavior from occuring. Signed-off-by: RJ Garcia <rj@bighead.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
If you have memcached or redis extensions installed
doctrine will try to automatically connect to one of them
if no cache paramter is set when dev mode is off. Defaulting
to ArrayCache to prevent that behavior from occuring.
Signed-off-by: RJ Garcia rj@bighead.net