Skip to content

Conversation

@joserick
Copy link

@joserick joserick commented Apr 6, 2022

Extend the base controller to be able to use middleware for each of the existing or custom actions. #181

Extend the base controller to be able to use middleware for each of the existing or custom actions.
@lindyhopchris
Copy link
Contributor

Hi. Thanks for submitting this PR but unfortunately I'm going to have to reject it. You can't extend App\Http\Controllers\Controller because that class isn't guaranteed to exist - e.g. the consuming application might be using a different namespace. In addition, as this is a package it should only use classes that it can install via Composer dependencies, so it will have to extend the Illuminate\Routing\Controller and retain the traits that I've already put on the class.

I think it'll be easier if I make these changes, so I'll close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants