Skip to content

Use attributes for PHPUnit 10 tests #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2023
Merged

Use attributes for PHPUnit 10 tests #631

merged 1 commit into from
May 8, 2023

Conversation

faustbrian
Copy link

Resolves #629

@jasonmccreary
Copy link
Collaborator

This looks good. However, please revert the @see conversion as these are not synonymous. the CoversClass has code coverage implications, whereas the @see is simply a reference.

@faustbrian
Copy link
Author

@jasonmccreary done

@jasonmccreary jasonmccreary merged commit 1722216 into laravel-shift:master May 8, 2023
@faustbrian faustbrian deleted the feat/phpunit10 branch May 8, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update PHPUnit test generation for PHPUnit 10
2 participants
@faustbrian @jasonmccreary