fix: resolve relative symlinks when skills path is outside project root#673
Merged
pushpak1300 merged 2 commits intolaravel:mainfrom Mar 16, 2026
Merged
fix: resolve relative symlinks when skills path is outside project root#673pushpak1300 merged 2 commits intolaravel:mainfrom
pushpak1300 merged 2 commits intolaravel:mainfrom
Conversation
When the skills path lives outside the project directory (e.g. ~/.claude/skills), relativePath() produced an absolute path because base_path() was not an ancestor of both paths. Introduce resolveBaseFromPaths() to find the true common ancestor so the symlink target is always relative.
…ase_path() Drop resolveBaseFromPaths() and rewrite relativePath() to derive the relative path from the two absolute paths by walking their common prefix — no dependency on base_path() or a separate helper method. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the skills path lives outside the project directory (e.g. ../../.claude/skills), relativePath() produced an absolute path because base_path() was not an ancestor of both paths. Introduce resolveBaseFromPaths() to find the true common ancestor so the symlink target is always relative.