Fix incomplete model discovery in GuidelineAssist class#749
Closed
iz-ahmad wants to merge 3 commits intolaravel:mainfrom
Closed
Fix incomplete model discovery in GuidelineAssist class#749iz-ahmad wants to merge 3 commits intolaravel:mainfrom
iz-ahmad wants to merge 3 commits intolaravel:mainfrom
Conversation
Member
|
This isn’t a reliable way because if there’s an incorrect class throwing warnings and fatal errors the boost won’t start. |
Member
|
I’m considering removing this functionality as it adds unnecessary bloat to the context and isn’t helpful. Furthermore, there are so many edge cases to get it right. Today’s model can intelligently determine which model exists and which doesn’t by searching the codebase. |
Contributor
Author
Yeah, just saw your PR #754.. I understand, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #716
laravel-boost-application-infowas returning an incomplete model list (e.g., onlyUser) when asked any AI agent to list the models.Likely root cause was:
discover()inGuidelineAssist.phpused:here, passing
falsedisables autoloading, so any model classes that weren't already loaded in memory - would be silently skipped.Changes made
class_exists($className, false)withclass_exists($className)to allow Composer autoloading, ensuring all autoloadable models are discovered.discover()detects models that were not previously loaded.Thanks.