[main] [bug] Remove credential leak in database:open#132
Merged
joetannenbaum merged 5 commits intolaravel:mainfrom Apr 10, 2026
Merged
[main] [bug] Remove credential leak in database:open#132joetannenbaum merged 5 commits intolaravel:mainfrom
joetannenbaum merged 5 commits intolaravel:mainfrom
Conversation
info($url) printed the full connection URL including username and password to the terminal. Replaced with a neutral message. Closes laravel#83 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
database:openprints the full connection URL (including username and password) to the terminal viainfo($url). This leaks credentials to terminal scrollback, screen sharing, and logs.Replaced with a descriptive message that shows the database name, hostname, port, and cluster name - giving users the context they need to confirm they opened the correct database without exposing credentials.
Before:
postgres://user:password@hostname:5432/main?Name=my-cluster&Environment=...After:
Opening database "main" on "hostname:5432" (cluster: my-cluster)Closes #83
Test plan
./vendor/bin/pest- 33 tests pass./vendor/bin/pint --test- no style issues