Skip to content

[main] [cleanup] Remove commented-out dead code from EnvironmentVariables#137

Merged
joetannenbaum merged 1 commit intolaravel:mainfrom
JoshSalway:fix/remove-environment-variables-dead-code
Apr 10, 2026
Merged

[main] [cleanup] Remove commented-out dead code from EnvironmentVariables#137
joetannenbaum merged 1 commit intolaravel:mainfrom
JoshSalway:fix/remove-environment-variables-dead-code

Conversation

@JoshSalway
Copy link
Copy Markdown
Contributor

@JoshSalway JoshSalway commented Apr 7, 2026

Fixes #84

Summary

EnvironmentVariables.php has 28 lines of commented-out code at the bottom of the file from a previous implementation. Not referenced anywhere.

The commented code was an earlier approach to editing individual environment variables interactively. The current implementation uses file-based replacement instead. If interactive variable editing is needed in the future, it can be revisited as a new feature with a fresh implementation.

Before / After

// Before: file ends with 30 lines of commented-out code
    }
}

//         foreach ($toUpdate as $key) {
//             $this->form()->prompt($key, fn($resolver) => ...
//         }
//         spin(
//             fn() => $this->client->environments()->replaceVariables(
//                 ...
//             ),
//         );
//         success('Environment variables replaced');
//     }
// }

// After: file ends cleanly
    }
}

28 lines of commented-out code left over from a previous
implementation. Not referenced anywhere.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

Thanks for submitting a PR!

Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@joetannenbaum joetannenbaum merged commit 3a2e954 into laravel:main Apr 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup: EnvironmentVariables has 28 lines of commented-out code

2 participants